|
|
|
Hi Will!
Next week we will be reviewing the next issues to be solved. If you could attach the patch (diff) file to this issue it would be very helpful, making it much easier and faster to be applied. Some instructions about this are in the wiki http://www.karora.org/wiki/display/COO/Bug+Fixing Thank you for contributing! Kimie The patch is attached and was generated against Rev #371. I've tested it against one of my major in-house applications.
Happy patching! --will gilbert The patch was applied, as it can be seen, the solution is similar to the one used in TabPane in
SVN #378 Hi Will!
I need someone to test if the patch was correctly applied. Would you be able to do that? Only after someone else test it I can close the issue. thank you Kimie The uploaded file 'AccordionPaneTest.java' is a series of JUnit tests which give 100% of the 'AccordionPane.java' class
The uploaded file 'AccordionPaneDemo.zip' is an acceptance level demo/test of the AccordionPane class.
This demo can be used to demonstrate the effectiveness of the JavaScript patch which was submitted previously. Using the 'pom.xml' file one can switch between the Cooee core library v1.0.1 which does not contain the patch and the current SNAPSHOT which does. This demo will print to System.out when the 'ACTIVE_TAB_INDEX_CHANGED_PROPERTY' event is fired and will also visually switch target panels. This project was created using the cooee-simpleapp archetype, but was modified to have jettyuse port 9090. Usage: Unpack the zip, change to top directory, type mvn jetty:run, use a browser to point at localhost:9090 Excellent!!
I've added AccordionPaneTest to cooee.app.test package in cooee svn. The demo application is pretty good too! thank you very much, and also, I've reaffirm the invite the Karora team has made to you. Just tell us when you feel like. cheers! Re-opened to correct the fix version field
| ||||||||||||||||||||||||||||||||||||||||||||||||
COO-17)In the file "AccordionPane.js" there is a method "processTabClick"
ExtrasAccordionPane.processTabClick = function(echoEvent) {
.
.
.
if (accordion.getTabById(tabId).rendered) { accordion.selectTab(tabId, true); } else { // Connect to server with updated tab state such that non-rendered tab will be rendered. accordion.selectTab(tabId, false); EchoServerTransaction.connect(); }
};
should be:
ExtrasAccordionPane.processTabClick = function(echoEvent) {
.
.
.
if (accordion.getTabById(tabId).rendered) { accordion.selectTab(tabId, true); } else { // Connect to server with updated tab state such that non-rendered tab will be rendered. accordion.selectTab(tabId, false); }
.
.
.
EchoServerTransaction.connect();
};
or to match the changes which the Cooee Team made to TabPane.js
ExtrasAccordionPane.processTabClick = function(echoEvent) {
.
.
.
var fireEvent = (tabId != tabPane.activeTabId);
if (accordion.getTabById(tabId).rendered) { accordion.selectTab(tabId, true); } } else { accordion.selectTab(tabId, false); }
if (fireEvent) { // Connect to server with updated tab state such that non-rendered tab will be rendered. EchoServerTransaction.connect(); }
};